Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MP config instead of Config.create() in MP components. #3291

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Use MP config instead of Config.create() in MP components. #3291

merged 2 commits into from
Aug 26, 2021

Conversation

tomas-langer
Copy link
Member

Backport to 2.3.3 for #3290
Signed-off-by: Tomas Langer tomas.langer@oracle.com

@tomas-langer
Use MP config instead of Config.create() in MP conmponents.
8113d11 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer added this to the 2.3.3 milestone Aug 18, 2021
@tomas-langer tomas-langer self-assigned this Aug 18, 2021
@tomas-langer
Fix registry factory to handle MP config.
7630533 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
barchetta
barchetta reviewed Aug 26, 2021
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change any behavior for customers? Like order of config sources? If yes, is that a concern for a dot-dot release?

@tomas-langer tomas-langer merged commit 3d9cd95 into helidon-io:helidon-2.3.3 Aug 26, 2021
@tomas-langer tomas-langer deleted the 3285-mp-config-create-2.3.3 branch August 26, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

Assignees

@tomas-langer tomas-langer

Labels
None yet
Projects
None yet
Milestone
2.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@tomas-langer @barchetta