-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health check for OCI ObjectStorage that works in SE and MP #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spericas
changed the title
WIP: Health check for OCI ObjectStorage that works in SE and MP
Health check for OCI ObjectStorage that works in SE and MP
Jun 29, 2021
tomas-langer
requested changes
Jun 29, 2021
...age/src/main/java/io/helidon/integrations/oci/objectstorage/OciObjectStorageHealthCheck.java
Outdated
Show resolved
Hide resolved
...age/src/main/java/io/helidon/integrations/oci/objectstorage/OciObjectStorageHealthCheck.java
Outdated
Show resolved
Hide resolved
...age/src/main/java/io/helidon/integrations/oci/objectstorage/OciObjectStorageHealthCheck.java
Outdated
Show resolved
Hide resolved
...age/src/main/java/io/helidon/integrations/oci/objectstorage/OciObjectStorageHealthCheck.java
Outdated
Show resolved
Hide resolved
...age/src/main/java/io/helidon/integrations/oci/objectstorage/OciObjectStorageHealthCheck.java
Outdated
Show resolved
Hide resolved
...age/src/main/java/io/helidon/integrations/oci/objectstorage/OciObjectStorageHealthCheck.java
Outdated
Show resolved
Hide resolved
...age/src/main/java/io/helidon/integrations/oci/objectstorage/OciObjectStorageHealthCheck.java
Outdated
Show resolved
Hide resolved
...tstorage/src/main/java/io/helidon/integrations/oci/objectstorage/OciObjectStorageRxImpl.java
Outdated
Show resolved
Hide resolved
...age/src/main/java/io/helidon/integrations/oci/objectstorage/OciObjectStorageHealthCheck.java
Outdated
Show resolved
Hide resolved
...ectstorage/src/main/java/io/helidon/integrations/oci/objectstorage/OciObjectStorageImpl.java
Outdated
Show resolved
Hide resolved
…her built-in health checks. Verifies that a bucket is accessible (HTTP GET) using the OCI client API. In addition to the user-specific OCI credentials, it needs the namespace and bucket name. MP and SE examples have been updated to use the new health check. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
… and builder pattern based on Helidon conventions. Updated ObjectStore API with new request and responses for GetBucket. Updated samples for SE and MP. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
reviewed
Jul 1, 2021
examples/integrations/vault/hcp-reactive/src/main/resources/application.yaml
Outdated
Show resolved
Hide resolved
.../main/java/io/helidon/integrations/oci/objectstorage/health/OciObjectStorageHealthCheck.java
Outdated
Show resolved
Hide resolved
integrations/oci/objectstorage-health/src/test/resources/application.yaml
Outdated
Show resolved
Hide resolved
spericas
force-pushed
the
object-storage-health
branch
from
July 1, 2021 16:40
04d7b8d
to
9ce585f
Compare
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
approved these changes
Jul 1, 2021
...c/main/java/io/helidon/examples/integrations/oci/objectstorage/cdi/ObjectStorageCdiMain.java
Outdated
Show resolved
Hide resolved
.../main/java/io/helidon/integrations/oci/objectstorage/health/OciObjectStorageHealthCheck.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP.
Liveness health check for OCI ObjectStorage that works in SE and MP, like our other built-in health checks. Verifies that a bucket is accessible (HTTP GET) using the OCI client API. In addition to the user-specific OCI credentials, it needs the namespace and bucket name. MP and SE examples have been updated to use the new health check.
Current output for health check is shown below: `GET http://.../health/live
Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com