Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore path parameters when matching routes #3097

Merged
merged 5 commits into from
Jun 10, 2021

Conversation

spericas
Copy link
Member

@spericas spericas commented Jun 9, 2021

Ignore path parameters while matching routes. Some new tests, including a base class to avoid repeating code in some of the new tests.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

@spericas spericas self-assigned this Jun 9, 2021
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas changed the title WIP: Ignore path parameters while matching routes Ignore path parameters while matching routes Jun 9, 2021
@spericas spericas changed the title Ignore path parameters while matching routes Ignore path parameters when matching routes Jun 9, 2021
tomas-langer
tomas-langer previously approved these changes Jun 10, 2021
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas merged commit 264bee4 into helidon-io:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants