Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixed-case H1 prefix when rendered #3003

Merged
merged 1 commit into from
May 10, 2021
Merged

Fix mixed-case H1 prefix when rendered #3003

merged 1 commit into from
May 10, 2021

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented May 7, 2021

Resolves #3002

The H1 line was followed by a blank line and then the h1Prefix definition.

It appears that either

  • h1Prefix must be defined earlier in the file than the H1, or
  • the h1Prefix definition must be in the attribute assignment block immediately following the H1 line with no intervening blank lines.

Moving all attribute assignments before the H1 line resolved this.

Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com

Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
@tjquinno tjquinno requested a review from ljamen May 7, 2021 17:27
@tjquinno tjquinno self-assigned this May 7, 2021
@barchetta barchetta merged commit a440590 into helidon-io:master May 10, 2021
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exemplar doc page variant (SE/MP) displays in mixed case, not upper case
3 participants