Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delay computation in Retry policies #2938

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

martin-sladecek
Copy link
Contributor

Resolves #2937

Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. So the lastDelay was not set in context, basically. I see that PartialPublisher is dead code in the test. Could we remove it? I know you didn't add it, but just noticed that. Thanks.

@martin-sladecek
Copy link
Contributor Author

LGTM. So the lastDelay was not set in context, basically. I see that PartialPublisher is dead code in the test. Could we remove it? I know you didn't add it, but just noticed that. Thanks.

Done

@spericas spericas merged commit aac3eba into helidon-io:master Apr 19, 2021
aseovic pushed a commit to aseovic/helidon that referenced this pull request Apr 26, 2021
* Fix delay computation in Retry policies

Resolves helidon-io#2937

* 2937 Remove PartialPublisher (dead code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Retry.DelayingRetryPolicy does not work with delays
2 participants