Allow use of config to set up built-in disk space and heap memory health checks #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
tomas-langer
requested changes
Apr 15, 2021
| @@ -144,5 +151,19 @@ public Builder thresholdPercent(double threshold) { | |||
| this.threshold = threshold; | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Set up the heap space health check via config key, if present. | |||
There was a problem hiding this comment.
The javadoc should contain a table of config keys used, description and default value.
Example:
Configuration options:
* <table class="config">
* <caption>Secret configuration</caption>
* <tr>
* <th>key</th>
* <th>default value</th>
* <th>description</th>
* <th>builder method</th>
* </tr>
* <tr>
* <td>{@value CONFIG_KEY_THRESHOLD_PERCENT_SUFFIX}</td>
* <td>{@code 99.9}</td>
* <td>Percentage of heap memory that needs to be full for this health check to fail</td>
* <td>{@link #tresholdPercent(double}</td>
* </tr>
* </table>
There was a problem hiding this comment.
Added for both classes.
aseovic
pushed a commit
to aseovic/helidon
that referenced
this pull request
Apr 26, 2021
…lth checks (helidon-io#2934) * Allow set-up of built-in liveness checks using configuration Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2885