Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle startups with request scopes available from CDI #2933

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

spericas
Copy link
Member

Guard for the case in which a request scope object is already available from CDI but a request context is not. New test.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

…le from CDI but a request context is not. New test.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas changed the title WIP: Handle startups with request scopes available from CDI Handle startups with request scopes available from CDI Apr 14, 2021
@spericas spericas merged commit fb77018 into helidon-io:master Apr 14, 2021
aseovic pushed a commit to aseovic/helidon that referenced this pull request Apr 26, 2021
…le from CDI but a request context is not. New test. (helidon-io#2933)

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants