Hash equals #2871
Merged
Hash equals #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulparkinson
pushed a commit
that referenced
this pull request
Mar 29, 2021
* Use MessageDigest.isEqual()
aseovic
pushed a commit
to aseovic/helidon
that referenced
this pull request
Apr 26, 2021
* Use MessageDigest.isEqual()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing message digests it is a best practice to do a full comparison of every byte and not short circuit comparisons when the first difference is found.
This change replaces string comparison in http auth with
MessageDigest.isEqual()when comparing message digests.Fixes #2877