Add support for gRPC reflection #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
requested changes
Mar 4, 2021
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2019 Oracle and/or its affiliates. All rights reserved. | |||
| * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
This is wrong copyright format. Please use 2019, 2021.
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerImpl.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/ServiceDescriptor.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/ProtoReflectionService.java
Show resolved
Hide resolved
|
@tomas-langer Any chance we can get this merged? |
aseovic
added a commit
to aseovic/helidon
that referenced
this pull request
Apr 26, 2021
* gRPC reflection support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.