Add missing metrics coverage and ensure proper coverage of future metrics in gRPC #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
aseovic
approved these changes
Mar 4, 2021
spericas
approved these changes
Mar 4, 2021
paulparkinson
pushed a commit
that referenced
this pull request
Mar 29, 2021
…rics in gRPC (#2818) * grpc metrics fix Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
aseovic
pushed a commit
to aseovic/helidon
that referenced
this pull request
Apr 26, 2021
…rics in gRPC (helidon-io#2818) * grpc metrics fix Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2694
This PR adds support for some metrics annotations that are not currently handled in gRPC. It also reworks some of the gRPC code related to metrics to be data-driven as much as possible to simplify adding proper support for future metrics (should they ever appear).
It also adds tests to help verify that the gRPC code handles all the metrics annotations corresponding to the MP metric types (except those we explicitly exclude because we don't support them).
A new
README.mddescribes the steps needed to add support for a new metric in gRPC.I've done my best to make these changes consistent with what gRPC was already doing. I'll rely on the reviewers to make sure the changes are correct and complete.