Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download Kafka binaries from archive if not present on mirror #2768

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Download Kafka binaries from archive if not present on mirror #2768

merged 4 commits into from
Mar 12, 2021

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented Feb 15, 2021 •
edited
Loading

Only few latest versions of Kafka binaries are accessible over Apache mirror, download the latest one to keep the docker file from getting obsolete.

Signed-off-by: Daniel Kec daniel.kec@oracle.com

@danielkec
Lookup latest version of Kafka binaries
95f79fc 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec added the messaging Reactive Messaging label Feb 15, 2021
@danielkec danielkec self-assigned this Feb 15, 2021
@danielkec danielkec linked an issue Feb 15, 2021 that may be closed by this pull request
Errors in examples/messaging at the stage of building (Kafka) and running (JMS) applications #2763
Closed
@danielkec danielkec mentioned this pull request Feb 15, 2021
Closed
tomas-langer
tomas-langer requested changes Mar 8, 2021
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should always use an explicit version of dependencies, even in examples.
You can add this to README.md as a way to get the latest version.
We should never have code that can use unknown versions.

@danielkec danielkec changed the title Lookup latest version of Kafka binaries Download Kafka binaries from archive if not present on mirror Mar 8, 2021
@danielkec
Copyright fix
1509469 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
tomas-langer
tomas-langer approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielkec danielkec merged commit b2108bd into helidon-io:master Mar 12, 2021
paulparkinson pushed a commit that referenced this pull request Mar 29, 2021
@danielkec @paulparkinson
Download Kafka binaries from archive if not present on mirror (#2768)
f0ffe23 
* Download Kafka binaries from archive if not available on mirror

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
aseovic pushed a commit to aseovic/helidon that referenced this pull request Apr 26, 2021
@danielkec @aseovic
Download Kafka binaries from archive if not present on mirror (helido…
98d5faa 
…n-io#2768)

* Download Kafka binaries from archive if not available on mirror

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

@Verdent Verdent Awaiting requested review from Verdent

Assignees

@danielkec danielkec

Labels
messaging Reactive Messaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in examples/messaging at the stage of building (Kafka) and running (JMS) applications
2 participants
@danielkec @tomas-langer