Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instructions for enabling JSON-P for Health-Checks. #2528

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

michael-simons
Copy link
Contributor

No description provided.

@michael-simons
Copy link
Contributor Author

Just sent out the OCA.

@romain-grecourt
Copy link
Contributor

/trigger

docs/se/health/01_health.adoc Outdated Show resolved Hide resolved
docs/se/health/01_health.adoc Outdated Show resolved Hide resolved
@tomas-langer
Copy link
Member

Hi @michael-simons, thanks for your contribution. The HealthSupport in current version does not require explicit registration of JsonpSupport with WebServer. You have identified an error in our documentation, the correct (new) approach is actually simpler than both the original and your updated docs. Detail in review comments

@tomas-langer tomas-langer added contribution A PR contributed from outside of Helidon team. docs health SE labels Nov 19, 2020
@michael-simons
Copy link
Contributor Author

A nice. I was wondering, especially about enabling the support. I didn't have this in my examples and things have been working nevertheless. I fixed my PR.

@m0mus m0mus added this to the 2.2.0 milestone Nov 19, 2020
@tomas-langer
Copy link
Member

/trigger

@romain-grecourt romain-grecourt merged commit b30f67c into helidon-io:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution A PR contributed from outside of Helidon team. docs health SE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants