Graph QL #2504
Merged
Graph QL #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
danielkec
reviewed
Nov 11, 2020
danielkec
reviewed
Nov 12, 2020
...ile/graphql/server/src/main/java/io/helidon/microprofile/graphql/server/SchemaDirective.java
Outdated
Show resolved
Hide resolved
...profile/graphql/server/src/main/java/io/helidon/microprofile/graphql/server/JandexUtils.java
Outdated
Show resolved
Hide resolved
microprofile/graphql/server/src/main/java/io/helidon/microprofile/graphql/server/Schema.java
Outdated
Show resolved
Hide resolved
microprofile/graphql/server/src/main/java/io/helidon/microprofile/graphql/server/Schema.java
Outdated
Show resolved
Hide resolved
microprofile/graphql/server/src/main/java/io/helidon/microprofile/graphql/server/Schema.java
Outdated
Show resolved
Hide resolved
microprofile/graphql/server/src/main/java/io/helidon/microprofile/graphql/server/Schema.java
Outdated
Show resolved
Hide resolved
...ile/graphql/server/src/main/java/io/helidon/microprofile/graphql/server/SchemaGenerator.java
Show resolved
Hide resolved
tjquinno
reviewed
Nov 12, 2020
...rofile/graphql/server/src/main/java/io/helidon/microprofile/graphql/server/package-info.java
Outdated
Show resolved
Hide resolved
microprofile/graphql/server/src/main/resources/META-INF/microprofile-config.properties
Outdated
Show resolved
Hide resolved
...le/graphql/server/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension
Outdated
Show resolved
Hide resolved
Merge issue fix.
tomas-langer
changed the title
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tjquinno
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
I've glanced at the changes you made in response to my earlier suggestions, and this approval reflects that re-look.
I made one very small suggestion; make the change ONLY if you happen to be working in that same file for some other, more important reason. (Normally the tests will be passing so none of the asserts will skip the server shutdown, so it's not a big deal.)
graphql/server/src/test/java/io/helidon/graphql/server/GraphQlSupportTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.