Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable automatic propagation from security providers #2357

Merged
merged 7 commits into from
Sep 30, 2020
Merged

Disable automatic propagation from security providers #2357

merged 7 commits into from
Sep 30, 2020

Conversation

tomas-langer
Copy link
Member

Resolves #2275

Added detailed provider documentation.
Providers now require outbound section in configuration (or through a builder via OutboundConfig) to add outbound security to outbound requests.

@tomas-langer tomas-langer added security 2.x Issues for 2.x version branch labels Sep 14, 2020
@tomas-langer tomas-langer self-assigned this Sep 14, 2020
@tomas-langer tomas-langer marked this pull request as draft September 14, 2020 16:26
@tomas-langer tomas-langer added this to the 2.1.0 milestone Sep 15, 2020
@tomas-langer tomas-langer marked this pull request as ready for review September 15, 2020 16:38
ljamen
ljamen previously approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed doc review of the 47 files.

docs/common/security/providers/google-login.adoc Outdated Show resolved Hide resolved
docs/common/security/providers/http-basic-auth.adoc Outdated Show resolved Hide resolved
docs/common/security/providers/http-basic-auth.adoc Outdated Show resolved Hide resolved
docs/common/security/providers/jwt.adoc Outdated Show resolved Hide resolved
...rity/providers/common/src/main/java/io/helidon/security/providers/common/OutboundTarget.java Outdated Show resolved Hide resolved
Verdent
Verdent previously approved these changes Sep 23, 2020
View reviewed changes
@tomas-langer tomas-langer linked an issue Sep 23, 2020 that may be closed by this pull request
Documentation for Security providers #2273
Closed
danielkec
danielkec previously approved these changes Sep 25, 2020
View reviewed changes
@tomas-langer
Squashable-1
f9f8c19 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Security providers no long automatically propagate.
fc4a8ff 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Fixed tests and examples.
dfdfe7d 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Review fix.
8e52e92 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Fixed documentation review issues.
3bff318 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Review fixes.
99fe7fe 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Moved security to shared from common to align with other docs.
4bf4ac9 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Copy link
Member Author

Rebased, moved from common to shared, as that is how other modules do it.

@tomas-langer tomas-langer merged commit 7f1a1ad into helidon-io:master Sep 30, 2020
@tomas-langer tomas-langer deleted the 2275-auto-propagate branch September 30, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkec danielkec danielkec approved these changes

@Verdent Verdent Verdent approved these changes

@ljamen ljamen Awaiting requested review from ljamen

Assignees

@tomas-langer tomas-langer

Labels
2.x Issues for 2.x version branch docs security
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Security providers should not automatically propagate security Documentation for Security providers
4 participants
@tomas-langer @danielkec @Verdent @ljamen