Security CDI extension has higher priority #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abac now correctly handles validator config Other services that expose endpoints have changed priority
Abac now correctly handles validator config Other services that expose endpoints have changed priority
tjquinno
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abac now correctly handles validator config
Security MP service must have higher priority than services exposing endpoints (such as metrics, health), so we can protect these endpoints.
In addition when an endpoint was protected using abac, each validator tried to read the configuration and time validator threw an exception.
Resolves #2296
Resolves #2297
For 2.x
I have modified priorities of services that configure endpoint to be library before, so they are configured before application (metrics, health, openapi) and security, which must be configured before them (to be able to protect these endpoints)