Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set junit4 version where used. Fixes #2289 #2290

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

barchetta
Copy link
Member

Fixes #2289

I did not put the junit 4 version in dependency management since Helidon uses Junit 5. Instead the version is specified in the one place where it is needed.

@barchetta barchetta added the 2.x Issues for 2.x version branch label Aug 26, 2020
@barchetta barchetta added this to the 2.0.2 milestone Aug 26, 2020
@barchetta barchetta self-assigned this Aug 26, 2020
@barchetta
Copy link
Member Author

barchetta commented Aug 26, 2020

mvn org.apache.maven.plugins:maven-help-plugin:3.2.0:effective-pom -Dverbose shows:

  <dependencyManagement>
    <dependencies>   
. . .
      <dependency>
        <groupId>junit</groupId>  <!-- com.fasterxml.jackson:jackson-parent:2.11, line 76 -->
        <artifactId>junit</artifactId>  <!-- com.fasterxml.jackson:jackson-parent:2.11, line 77 -->
        <version>4.12</version>  <!-- com.fasterxml.jackson:jackson-parent:2.11, line 78 -->
      </dependency>
    </dependencies>
  </dependencyManagement>

@barchetta barchetta merged commit 18034ca into helidon-io:master Aug 26, 2020
@barchetta barchetta deleted the add-junit4-version branch December 17, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

junit version in microprofile/tests/arquillian/pom.xml is not managed by Helidon
3 participants