Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces an ExecutorServices implementation to Helidon's repackaged Weld implementation to ensure context classloaders are never null #2269

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Introduces an ExecutorServices implementation to Helidon's repackaged Weld implementation to ensure context classloaders are never null #2269

merged 3 commits into from
Sep 1, 2020

Conversation

ljnelson
Copy link
Member

Signed-off-by: Laird Nelson laird.nelson@oracle.com

@ljnelson
Introduces an ExecutorServices implementation to Helidon's repackaged…
78fb8b9 
… Weld implementation to ensure context classloaders are never null.

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson self-assigned this Aug 18, 2020
@ljnelson ljnelson added the P3 label Aug 18, 2020
@ljnelson ljnelson linked an issue Aug 18, 2020 that may be closed by this pull request
NullPointerException in MetaConfigFinder in CDI situations #2207
Closed
@ljnelson
Copy link
Member Author

@tomas-langer @romain-grecourt I am not sure if I have put this ExecutorServices implementation in the right place. While this PR is draft, could you at least tell me if it is an OK place for this file to go? I have verified that it is recognized and loaded and its wrap method is called. I've done nothing else yet.

@tomas-langer
Copy link
Member

This module is only for repackaged code (e.g. stuff we need to modify in Weld).
If you need to update something through SPI or API of Weld, please add it to microprofile/cdi module (HelidonProxyServices is also located here).

Regarding the bug you are fixing - we need to make sure, that the components always get the same instance of MP Config, regardless of the lifecycle of CDI - otherwise we would still get issues when using a customized config instance.

@ljnelson
Squashable commit; relocated things per PR feedback
1bda2b3 
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson
Squashable commit; added information to module-info.java, though stri…
016c4af 
…ctly speaking it is not necessary since Weld does not load services using the JDK service loader

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@tomas-langer
Copy link
Member

Looks good.

@ljnelson ljnelson marked this pull request as ready for review August 20, 2020 21:38
@barchetta barchetta added this to the 2.0.2 milestone Aug 31, 2020
@ljnelson ljnelson merged commit 8b58ec5 into helidon-io:master Sep 1, 2020
@barchetta barchetta mentioned this pull request Sep 2, 2020
Closed
@ljnelson ljnelson mentioned this pull request Jan 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@ljnelson ljnelson

Labels
P3
Projects
Backlog
Archived in project
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

NullPointerException in MetaConfigFinder in CDI situations
3 participants
@ljnelson @tomas-langer @barchetta