Make sure request scope is propagated to newly created threads in FT #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
ljnelson
reviewed
Aug 3, 2020
...l/context-propagation/src/test/java/io/helidon/tests/functional/context/hello/HelloTest.java
Outdated
Show resolved
Hide resolved
ljnelson
previously approved these changes
Aug 3, 2020
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
ljnelson
approved these changes
Aug 3, 2020
|
/trigger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing the solution with @jansupol, I believe this is currently the simplest way to support this. We do need to create a dummy CDI bean with an injection point for Jersey to make its
RequestScopetype available via CDI. Using that and some other CDI classes, we ensure all injections (@Contextor@Injectones) are available in newly created threads.One of the functional tests has been updated to verify this fix.