Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickstart gradle fixes #2214

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Quickstart gradle fixes #2214

merged 3 commits into from
Jul 29, 2020

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Jul 24, 2020 •
edited
Loading

  • Fix dependencies
  • Use correct main class
  • Enable Junit tests

@barchetta barchetta added examples 2.x Issues for 2.x version branch labels Jul 24, 2020
@barchetta barchetta added this to the 2.0.2 milestone Jul 24, 2020
@barchetta barchetta self-assigned this Jul 24, 2020
This was referenced Jul 24, 2020
Closed
Closed
romain-grecourt
romain-grecourt approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps @aalmiray should have the last call on this one.

@aalmiray
Copy link

LGTM. Ship it! 😏

@barchetta barchetta merged commit 0b261b1 into helidon-io:master Jul 29, 2020
@barchetta barchetta deleted the gradle-improvements branch July 29, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalmiray aalmiray aalmiray left review comments

@romain-grecourt romain-grecourt romain-grecourt approved these changes

Assignees

@barchetta barchetta

Labels
2.x Issues for 2.x version branch examples
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@barchetta @aalmiray @romain-grecourt