-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update microprofile examples to use microprofile-config.properties #2163
Conversation
(Full disclaimer: haven't looked in detail at this.) MicroProfile Config does support arrays of things natively. For example, if this is in a
…or:
…and you include it like this:
…or you get it like this:
…I believe it is supposed to be handled automatically by all conformant implementations (such as ours), though I'm typing off the cuff here so be kind in terms of syntax 😄 . Were you not seeing this? |
Put back int list in the example that used them. |
``` | ||
|
||
By default the server will use a dynamic port, see the messages displayed | ||
when the application starts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked deeply but down below you set the port to 7001, so will a dynamic port truly be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the explicit example it uses a dynamic port. In the implicit example it uses 7001.
Changed these two examples to use microprofile-config.properties (and not application.yaml).
This required removing the integer array in config (supported by yaml, not properties).