Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Dockerfiles to use maven.test.skip (not skipTests) #2135

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Change Dockerfiles to use maven.test.skip (not skipTests) #2135

merged 1 commit into from
Jul 7, 2020

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Jul 6, 2020 •
edited
Loading

See issue #2128

This changes Dockerfiles to use maven.test.skip when priming dependencies into the local maven cache to avoid attempting test compilation.

@barchetta barchetta added the 2.x Issues for 2.x version branch label Jul 6, 2020
@barchetta barchetta self-assigned this Jul 6, 2020
ljnelson
ljnelson approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barchetta barchetta merged commit d59626d into helidon-io:master Jul 7, 2020
@barchetta barchetta deleted the maven-test-skip-dockerfile branch July 13, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljnelson ljnelson ljnelson approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@barchetta barchetta

Labels
2.x Issues for 2.x version branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barchetta @ljnelson