Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use path() when creating invocations #2116

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

spericas
Copy link
Member

@spericas spericas commented Jul 1, 2020

Fixes issue #1949. Properly use path() when creating an invocation using the JAX-RS API. Note that this PR does not address the closing of Response's. Although technically correct, it isn't really a problem in tests and tends to make the code less readable.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

…ocation using the JAX-RS API.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas added this to the 2.0.2 milestone Jul 1, 2020
@spericas spericas requested a review from barchetta July 1, 2020 17:19
@spericas spericas self-assigned this Jul 1, 2020
@spericas spericas changed the title Properly use path() when creating an invocations Properly use path() when creating invocations Jul 1, 2020
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit 587c4c2 into helidon-io:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants