SE Config can be created from MP Config #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are a few test failures and a SpotBugs issue to address. As for the implementation, I understand and agree with the overall approach, but can't really provide much feedback on the actual implementation. |
danielkec
reviewed
Jun 19, 2020
| @@ -605,6 +584,7 @@ private EmptyConfigHolder() { | |||
| .disableSystemPropertiesSource() | |||
| .disableParserServices() | |||
| .disableFilterServices() | |||
| .changesExecutor(command -> {}) | |||
There was a problem hiding this comment.
Maybe we could add some disableMutableSources or something similar in the future
danielkec
reviewed
Jun 19, 2020
config/config-mp/src/test/java/io/helidon/config/mp/MpConfigTest.java
Outdated
Show resolved
Hide resolved
danielkec
reviewed
Jun 19, 2020
config/config-mp/src/test/java/io/helidon/config/mp/MpConfigTest.java
Outdated
Show resolved
Hide resolved
danielkec
reviewed
Jun 19, 2020
...rofile/messaging/src/test/java/io/helidon/microprofile/messaging/AdHocConfigBuilderTest.java
Outdated
Show resolved
Hide resolved
danielkec
previously approved these changes
Jun 19, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Empty config now does not create an executor service. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Added env var test. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
force-pushed
the
2059-mp-se-config
branch
from
eed6a3f
to
a5b2064
Compare
danielkec
previously approved these changes
Jun 19, 2020
…ailure fix) Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variables were not honored correctly - now we use MP config as the implementation and we have an SE config implementation fronting it when creating SE config from MP Config.
Resolves #2059