Minor gRPC fixes (2.0) #1951
Merged
Minor gRPC fixes (2.0) #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjquinno
approved these changes
Jun 9, 2020
Comment on lines
+73
to
+79
| VENDOR_REGISTRY.meter(org.eclipse.microprofile.metrics.Metadata.builder() | ||
| .withName("grpc.requests.meter") | ||
| .withDisplayName("Meter for overall gRPC requests") | ||
| .withDescription("Each gRPC request will mark the meter to see overall throughput") | ||
| .withType(MetricType.METERED) | ||
| .withUnit(MetricUnits.NONE) | ||
| .build()); |
There was a problem hiding this comment.
I see that this takes the place of the meter that used to be registered in MetricsSupport. There is no replacement here for the counter that MetricsSupport used to register. Is that intentional?
There was a problem hiding this comment.
Yes -- meter already has a counter, so having a separate counter is a bit pointless.
tjquinno
added a commit
that referenced
this pull request
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor gRPC metrics cleanup and fix for Channel injection