Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature refactoring #1944

Merged
merged 4 commits into from
Jun 16, 2020
Merged

Feature refactoring #1944

merged 4 commits into from
Jun 16, 2020

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Jun 8, 2020 •
edited
Loading

Update to feature design

  • driven by included package names
  • feature database now in the source code

Output now works including description of features:

Helidon MP 2.0.0-SNAPSHOT features: [CDI, Config, Metrics, Security, Tracing]
Detailed feature tree:
CDI       Jakarta CDI
Config    MicroProfile Configuration
  YAML    YAML file support
Metrics   MP Metrics specification support
Security  Security for Helidon MP
Tracing   Tracing support
  Jaeger  Jaeger tracer support

Resolves #1914

@tomas-langer tomas-langer self-assigned this Jun 8, 2020
@tomas-langer tomas-langer force-pushed the feature-design branch 2 times, most recently from 375f16b to d6a6f76 Compare June 9, 2020 14:47
@tomas-langer tomas-langer changed the title Feature design Feature simplification Jun 9, 2020
@tomas-langer tomas-langer marked this pull request as ready for review June 9, 2020 14:47
@tomas-langer tomas-langer mentioned this pull request Jun 11, 2020
Closed
@tomas-langer
Features simplification.
8f6972f 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Required classes were missing from commit.
eb4c1be 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Copy link
Member Author

tomas-langer commented Jun 11, 2020 •
edited
Loading

Adding additional packages and ensuring we get a proper warning about unsupported features when building native image.

Example:

[INFO] 2020.06.11 17:53:47 WARNING io.helidon.common.HelidonFeatures: MP feature 'REST Client' for path 'RESTClient' has limited support in native image: Does not support execution of default methods on interfaces

Example of unsupported feature:

SEVERE: Feature 'Google Login' for path 'Security/Provider/Google-Login' IS NOT SUPPORTED in native image. Image may still build and run.

@tomas-langer
* Added additional features and excludes
9fe576d 
* Moved initialization of log to native image extension
* Log statements for unsupported features in native image

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Checkstyle fixes.
66d2103 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer linked an issue Jun 11, 2020 that may be closed by this pull request
Log a warning for native image #1798
Closed
@tomas-langer tomas-langer added this to the 2.0.0 milestone Jun 11, 2020
@tomas-langer tomas-langer changed the title Feature simplification Feature refactoring Jun 11, 2020
This was referenced Jun 11, 2020
Closed
Closed
spericas
spericas approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomas-langer tomas-langer merged commit 4abd0a3 into helidon-io:master Jun 16, 2020
@tomas-langer tomas-langer deleted the feature-design branch June 24, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@tomas-langer tomas-langer

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Evaluate Features feature for 2.0.0 Log a warning for native image
2 participants
@tomas-langer @spericas