-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: New JPA example and archetype using Pokemons #1933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljnelson
requested changes
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically looks fine to me; a couple of minor changes are recommended.
...cdi/pokemons/src/main/java/io/helidon/examples/integrations/cdi/pokemon/PokemonResource.java
Outdated
Show resolved
Hide resolved
...cdi/pokemons/src/main/java/io/helidon/examples/integrations/cdi/pokemon/PokemonResource.java
Outdated
Show resolved
Hide resolved
...cdi/pokemons/src/main/java/io/helidon/examples/integrations/cdi/pokemon/PokemonResource.java
Show resolved
Hide resolved
...pokemons/src/main/java/io/helidon/examples/integrations/cdi/pokemon/PokemonTypeResource.java
Outdated
Show resolved
Hide resolved
examples/integrations/cdi/pokemons/src/main/resources/META-INF/init_script.sql
Show resolved
Hide resolved
examples/integrations/cdi/pokemons/src/main/resources/META-INF/microprofile-config.properties
Outdated
Show resolved
Hide resolved
tomas-langer
previously requested changes
Jun 5, 2020
examples/integrations/cdi/pokemons/src/main/resources/META-INF/microprofile-config.properties
Outdated
Show resolved
Hide resolved
examples/integrations/cdi/pokemons/src/main/resources/META-INF/persistence.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…w archetype. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
… changes. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…adding the 'bare-' prefix. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
changed the title
WIP: New JPA MP test using Pokemons
WIP: New JPA example and archetype using Pokemons
Jun 9, 2020
ljnelson
reviewed
Jun 10, 2020
...cdi/pokemons/src/main/java/io/helidon/examples/integrations/cdi/pokemon/PokemonResource.java
Show resolved
Hide resolved
ljnelson
previously approved these changes
Jun 10, 2020
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
ljnelson
reviewed
Jun 11, 2020
examples/integrations/cdi/pokemons/src/main/resources/META-INF/microprofile-config.properties
Show resolved
Hide resolved
ljnelson
reviewed
Jun 11, 2020
...pokemons/src/main/java/io/helidon/examples/integrations/cdi/pokemon/PokemonTypeResource.java
Show resolved
Hide resolved
ljnelson
reviewed
Jun 11, 2020
ljnelson
reviewed
Jun 11, 2020
archetypes/database-mp/src/main/resources/src/main/resources/native-image/reflect-config.json
Show resolved
Hide resolved
ljnelson
approved these changes
Jun 11, 2020
spericas
dismissed
tomas-langer’s stale review
June 11, 2020 18:44
Will follow up with @tomas-langer on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
bare-mp
andbare-se
Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com