Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New JPA example and archetype using Pokemons #1933

Merged
merged 12 commits into from
Jun 11, 2020

Conversation

spericas
Copy link
Member

@spericas spericas commented Jun 4, 2020

This PR includes:

  • New DB example using MP
  • New archetype based on the example
  • Renaming of existing archetype directories bare-mp and bare-se

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks fine to me; a couple of minor changes are recommended.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…w archetype.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
… changes.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…adding the 'bare-' prefix.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas changed the title WIP: New JPA MP test using Pokemons WIP: New JPA example and archetype using Pokemons Jun 9, 2020
@spericas spericas added the 2.x Issues for 2.x version branch label Jun 10, 2020
@spericas spericas added this to the 2.0.0 milestone Jun 10, 2020
ljnelson
ljnelson previously approved these changes Jun 10, 2020
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas dismissed tomas-langer’s stale review June 11, 2020 18:44

Will follow up with @tomas-langer on this

@spericas spericas merged commit e415a72 into helidon-io:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants