Static content handlers now use explicit writers. #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
added
webserver
2.x
4 tasks
|
@romain-grecourt I think that static content, metrics and health do not need to mark the used content writer in tracing (as long as we know the endpoint was handled by metrics, health, or static content), as these are hardcoded (and cannot be changed by user). |
romain-grecourt
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
I guess this can go in as-is. We can make more changes once #2010 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomas Langer tomas.langer@oracle.com
Related to #1588