Moving 2 tests from KafkaMP to KafkaSE #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
|
@danielkec is this PR ready to be merged ? |
danielkec
reviewed
Jun 11, 2020
| Map<String, Object> config = new HashMap<>(); | ||
| config.put("bootstrap.servers", KAFKA_SERVER); | ||
| config.put("key.serializer", LongSerializer.class.getName()); | ||
| config.put("value.serializer", StringSerializer.class.getName()); |
There was a problem hiding this comment.
This config seems not to be used anywhere
There was a problem hiding this comment.
I forgot to remove it. Now that config is in AbstractKafkaTest.produceAndCheck
danielkec
reviewed
Jun 11, 2020
| Map<String, Object> config = new HashMap<>(); | ||
| config.put("bootstrap.servers", KAFKA_SERVER); | ||
| config.put("key.serializer", LongSerializer.class.getName()); | ||
| config.put("value.serializer", StringSerializer.class.getName()); |
|
I have ran it 1564 times locally and it seems super stable 👍 |
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
danielkec
approved these changes
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the issues of that disabled 2 tests, because there is no other consumer in the moment we get the uncommitted events from Kafka.