Deprecated Multi#from #1888
Merged
Deprecated Multi#from #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should go ahead and remove these API, RC1 is really close ; we shouldn't be deprecating APIs at this stage ; @tomas-langer WDYT ? |
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec
force-pushed
the
multi-helidon-fluent-api-align
branch
from
ec00c05
to
38a295a
Compare
|
@romain-grecourt @tomas-langer If we want to align Multi with the Helidon fluent api, we should be careful not to discourage users coming in with previous knowledge of other reactive libraries. I would like to leave a breadcrumbs for them in the shape of intentionally deprecated |
Signed-off-by: Daniel Kec <daniel.kec@oracle.com> Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com> Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
|
I think this approach is OK. And if we have big enough traction, we can eventually remove them (in 3.0, or 4.0...) |
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Kec daniel.kec@oracle.com