New application types (templates) for the CLI #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded following the same structure and naming convention that is part of the contract in with the CLI's init command. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
romain-grecourt
requested changes
May 14, 2020
There was a problem hiding this comment.
Lets use io.helidon.archetypes groupId and move these into the archetypes top level directory.
No need to remove the bare archetypes yet.
Can you also add some tests for the archetypes, see https://github.com/oracle/helidon-build-tools/tree/master/helidon-archetype/maven-plugin/src/it/projects/archetype1/src/test/resources/projects/it1
apptypes/mp/basic/src/main/resources/META-INF/helidon-archetype-resources.txt
Outdated
Show resolved
Hide resolved
apptypes/se/basic/src/main/resources/META-INF/helidon-archetype-resources.txt
Outdated
Show resolved
Hide resolved
…oms. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
|
Fyi @romain-grecourt
|
tomas-langer
requested changes
May 15, 2020
archetypes/mp/basic/src/main/resources/src/main/java/__pkg__/GreetResource.java.mustache
Outdated
Show resolved
Hide resolved
archetypes/mp/basic/src/main/resources/src/main/java/__pkg__/GreetResource.java.mustache
Outdated
Show resolved
Hide resolved
archetypes/se/basic/src/main/resources/src/main/java/__pkg__/Main.java.mustache
Outdated
Show resolved
Hide resolved
archetypes/se/basic/src/main/resources/src/main/java/__pkg__/Main.java.mustache
Outdated
Show resolved
Hide resolved
romain-grecourt
previously approved these changes
May 15, 2020
There was a problem hiding this comment.
Approving to clear my previous review. This is good to go when the items from @tomas-langer are resolved.
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New application types (templates) for the CLI. More templates can be added following the same structure and naming convention that is part of the contract in with the CLI's init command.
Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com