Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi from InputStream #1770

Merged
merged 3 commits into from
May 28, 2020
Merged

Multi from InputStream #1770

merged 3 commits into from
May 28, 2020

Conversation

danielkec
Copy link
Contributor

Alternative impl for InputStreamPublisher #1741

@danielkec danielkec added the reactive Reactive streams and related components label May 12, 2020
@danielkec danielkec self-assigned this May 12, 2020
tomas-langer
tomas-langer requested changes May 13, 2020
View reviewed changes
common/reactive/src/main/java/io/helidon/common/reactive/Multi.java Outdated Show resolved Hide resolved
common/reactive/pom.xml Outdated Show resolved Hide resolved
@danielkec danielkec changed the title [WIP] Multi from InputStream Multi from InputStream May 13, 2020
@romain-grecourt romain-grecourt mentioned this pull request May 14, 2020
Closed
@danielkec
Multi from InputStream
4d7a2aa
@danielkec
Switch to MultiFromInputStream
864d7bb 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Move MultiFromInputStream to IoMulti builder
3664001 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec added this to the 2.0.0-RC1 milestone May 28, 2020
tomas-langer
tomas-langer approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danielkec danielkec merged commit c7f4b31 into helidon-io:master May 28, 2020
@tomas-langer tomas-langer mentioned this pull request May 30, 2020
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@akarnokd akarnokd Awaiting requested review from akarnokd

Assignees

@danielkec danielkec

Labels
api-change reactive Reactive streams and related components
Projects
None yet
Milestone
2.0.0-RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@danielkec @tomas-langer