Improve handling of missing config nodes used to init CORS objects #1709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1708
If a missing config node is passed to
CorsSupport.Builder.config
(directly or indirectly viaCorsSupport.create(Config)
, create a defaultCorsSupport
instance which is by design rather permissive: allow-methods = *, etc. Same forCorsSupportMp
.Log an
INFO
message when this happens.Add tests for this behavior.