Add CORS support to built-in Helidon services #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etailed logging for CORS support
…method instead of corsConfig(Config) to conform to other builder patterns
tomas-langer
previously approved these changes
Apr 22, 2020
…st slows things down)
tjquinno
changed the title
tjquinno
changed the title
tjquinno
changed the title
…nfig entry just enables CORS without specifying any further info; add FINER matching logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1573
These changes add support for CORS to the built-in Helidon services health, metrics, and OpenAPI.
This gist summarizes the support from a user's point of view and outlines the coding changes needed in a service to be CORS-enabled: https://gist.github.com/tjquinno/537452625c9f2f732a53997282343524