Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order the apps to run by class name to provide more predictable ordering #1593

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Order the apps to run by class name to provide more predictable ordering #1593

merged 2 commits into from
Mar 27, 2020

Conversation

tjquinno
Copy link
Member

Resolves #1545

The SnakeYAML code itself seems to preserve insertion ordering when it creates output documents.

To provide more predictable ordering in the OpenAPI document, this PR sorts the Application objects retrieved from the server's CDI extension by class name before submitting them to SmallRye's annotation processing. SnakeYAML should preserve the ordering of endpoints within each app.

@tjquinno tjquinno self-assigned this Mar 27, 2020
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit d164ee9 into helidon-io:master Mar 27, 2020
@tjquinno tjquinno deleted the openapi-orderdoc-2.x branch March 27, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override SnakeYAML output ordering for OpenAPI documents
2 participants