Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB Example now correctly non-blocking #1584

Merged
merged 6 commits into from
Mar 30, 2020
Merged

DB Example now correctly non-blocking #1584

merged 6 commits into from
Mar 30, 2020

Conversation

tomas-langer
Copy link
Member

As part of this PR, I had to fix a few problems:

  1. Sending a throwable using Response.send() did not set 500 status code
  2. DB Client did not map to String (such as from BigDecimal)
  3. There was a compilation issue in one of the native-image integration tests

@tomas-langer
Public API to obtain a JDBC specific builder.
32bd61e 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Support to map any column to String using String.valueOf().
9768229 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Sending a throwable now correctly uses 500 status code. Used 200 before.
949b24b 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Update to example to use db client instead of direct JDBC, to be corr…
bff6c9a 
…ectly non-blocking.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Update to native-image test (compilation fix + test was missing)
5907689 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer added examples 2.x Issues for 2.x version branch reactive Reactive streams and related components DB client Helidon DB Client labels Mar 26, 2020
@tomas-langer tomas-langer self-assigned this Mar 26, 2020
@tomas-langer
Javadoc fix.
bd8926e 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer merged commit 5bd6290 into helidon-io:master Mar 30, 2020
@tomas-langer tomas-langer deleted the 1583-example-reactive-db branch March 30, 2020 08:51
@tomas-langer tomas-langer mentioned this pull request Apr 2, 2020
Closed
@tomas-langer tomas-langer linked an issue Apr 2, 2020 that may be closed by this pull request
Employee app example has reactive issues #1583
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@barchetta barchetta Awaiting requested review from barchetta

Assignees

@tomas-langer tomas-langer

Labels
2.x Issues for 2.x version branch DB client Helidon DB Client examples reactive Reactive streams and related components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Employee app example has reactive issues
2 participants
@tomas-langer @romain-grecourt