Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TracerResolver. #1574

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

tomas-langer
Copy link
Member

Fixes #1384
Signed-off-by: Tomas Langer tomas.langer@oracle.com

OpenTracing contrib includes a way to add tracer using a service loader. We have explicit support for Jaeger and Zipkin, this would add a generic support for any tracer, although without support for configuration using Helidon config - the configuration is ignored except for:

# Whether the tracer is enabled (defaults to true)
enabled: true
# Service name - used only to log a statement, IGNORED for the actual tracing
service: "name"
# Whether to register this tracer as a global tracer (defaults to false)
global: true

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer added tracing dependencies Pull requests that update a dependency file labels Mar 24, 2020
@tomas-langer tomas-langer self-assigned this Mar 24, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer merged commit cf5780c into helidon-io:master Mar 30, 2020
@tomas-langer tomas-langer deleted the 1384-tracer-resolver branch March 30, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use OT Tracer Resolver
3 participants