[Reactive] Workaround for an RS 1.0.3 TCK bug #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/oca-checked |
danielkec
reviewed
Mar 24, 2020
Comment on lines
+541
to
+542
| // Workaround for a TCK bug when calling cancel() from any method named onComplete(). | ||
| private static volatile ExecutorService coupledExecutor = ForkJoinPool.commonPool(); |
There was a problem hiding this comment.
For future reference TCK fix: reactive-streams/reactive-streams-jvm#483
danielkec
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross cancellation from an
onError/onCompletemethod is not correctly verified by the Reactive Streams TCK. There is a patch waiting to be included but it could take an arbitrary amount of time to get it in a released form.In addition, the original workaround of using the ForkJoinPool sometimes doesn't work because the FJP executes the task on the caller thread, thus triggering the TCK bug again.
This PR adds a workaround in the form of a configurable ExecutorService which is set to a single-threaded one for the duration of the TCK.