Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completable queue and clean-up of messaging tests #1499

Merged
merged 5 commits into from
Mar 17, 2020

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented Mar 12, 2020

  • Hamcrestination
  • Flaky tests fix
  • Back-pressure aware completable queue
  • Source acknowledgement

Signed-off-by: Daniel Kec daniel.kec@oracle.com

  * Hamcrestination
  * Flaky tests fix

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec self-assigned this Mar 12, 2020
@danielkec danielkec added this to the 2.0.0 milestone Mar 12, 2020
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec changed the title Clean-up of messaging tests Fix completable queue and clean-up of messaging tests Mar 13, 2020
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RedeemingCompletionSubscriber - contains CompletionStage.toCompletableFuture().complete... calls that are wrong.
Please refactor to correctly use completable future.

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec merged commit 01b6b74 into helidon-io:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants