Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mappers for database date/time/timestamps. #1485

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Mappers for database date/time/timestamps. #1485

merged 4 commits into from
Mar 10, 2020

Conversation

Tomas-Kraus
Copy link
Member

No description provided.

@Tomas-Kraus
Mappers for database date/time/timestamps.
54ce6eb 
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
@Tomas-Kraus Tomas-Kraus self-assigned this Mar 10, 2020
@Tomas-Kraus Tomas-Kraus mentioned this pull request Mar 10, 2020
Closed
@Tomas-Kraus
Copy link
Member Author

Fixes Issue #1454

@Tomas-Kraus
Fixed javadocs.
f7bee3d 
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
tomas-langer
tomas-langer requested changes Mar 10, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor:

  • use a single package (flat package structure is a requirement for Helidon)
  • the Mapper classes should be either internal classes of the MapperProvider, or may be just lambdas

@Tomas-Kraus
Review notes aplpied.
fc9ea6c 
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
@Tomas-Kraus
Code cleanup.
4a6177d 
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
@tomas-langer tomas-langer merged commit 41220ce into helidon-io:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@Tomas-Kraus Tomas-Kraus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tomas-Kraus @tomas-langer