716 mp revamp #1259
Merged
716 mp revamp #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
force-pushed
the
716-mp-revamp
branch
from
40c17bd
to
0b3fa9f
Compare
tjquinno
previously approved these changes
Jan 2, 2020
|
Resolves #363 |
|
Resolves #1258 |
barchetta
reviewed
Jan 3, 2020
barchetta
reviewed
Jan 3, 2020
common/common/src/main/java/io/helidon/common/HelidonFeatures.java
Outdated
Show resolved
Hide resolved
ljnelson
requested changes
Jan 3, 2020
...ension/src/main/java/io/helidon/integrations/graal/mp/nativeimage/extension/WeldFeature.java
Show resolved
Hide resolved
...ension/src/main/java/io/helidon/integrations/graal/mp/nativeimage/extension/WeldFeature.java
Show resolved
Hide resolved
...ension/src/main/java/io/helidon/integrations/graal/mp/nativeimage/extension/WeldFeature.java
Show resolved
Hide resolved
...ension/src/main/java/io/helidon/integrations/graal/mp/nativeimage/extension/WeldFeature.java
Show resolved
Hide resolved
...ension/src/main/java/io/helidon/integrations/graal/mp/nativeimage/extension/WeldFeature.java
Show resolved
Hide resolved
microprofile/server/src/main/java/io/helidon/microprofile/server/Server.java
Show resolved
Hide resolved
microprofile/server/src/main/java/io/helidon/microprofile/server/ServerCdiExtension.java
Outdated
Show resolved
Hide resolved
microprofile/server/src/main/java/io/helidon/microprofile/server/ServerCdiExtension.java
Outdated
Show resolved
Hide resolved
microprofile/server/src/main/java/io/helidon/microprofile/server/ServerCdiExtension.java
Outdated
Show resolved
Hide resolved
microprofile/server/src/main/java/io/helidon/microprofile/server/ServerCdiExtension.java
Show resolved
Hide resolved
tomas-langer
force-pushed
the
716-mp-revamp
branch
from
533766c
to
f81ac95
Compare
spericas
previously approved these changes
Jan 6, 2020
tomas-langer
force-pushed
the
716-mp-revamp
branch
from
9a2fa23
to
7fa83b6
Compare
spericas
previously approved these changes
Jan 7, 2020
ljnelson
requested changes
Jan 7, 2020
| } | ||
|
|
||
| static synchronized void addListener(Runnable runnable) { | ||
| RESET_LISTENERS.add(runnable); |
There was a problem hiding this comment.
Is it OK I can add the same runnable twice?
There was a problem hiding this comment.
Depends on which runnable. There is only one place this is used from...
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonContainerImpl.java
Outdated
Show resolved
Hide resolved
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/HelidonContainerImpl.java
Outdated
Show resolved
Hide resolved
| // we need to workaround that logging stops printing output during shutdown hooks | ||
| // let's add a Handler | ||
|
|
||
| Thread shutdownHook = new Thread(() -> { |
There was a problem hiding this comment.
All I meant was: the stock Weld shutdown hook closes the CDI container. This one does too. They run in parallel. I don't know what kind of dropped events or threading issues might arise. Maybe none. Maybe some.
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/LogConfig.java
Show resolved
Hide resolved
microprofile/config/src/main/java/io/helidon/microprofile/config/ConfigCdiExtension.java
Show resolved
Hide resolved
microprofile/server/src/main/java/io/helidon/microprofile/server/Server.java
Show resolved
Hide resolved
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/BuildTimeEvent.java
Outdated
Show resolved
Hide resolved
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/BuildTimeEvent.java
Outdated
Show resolved
Hide resolved
microprofile/cdi/src/main/java/io/helidon/microprofile/cdi/BuildTimeEvent.java
Outdated
Show resolved
Hide resolved
tomas-langer
force-pushed
the
716-mp-revamp
branch
from
8b2e8dc
to
03a0379
Compare
20 tasks
|
Resolves #1152 |
tomas-langer
force-pushed
the
716-mp-revamp
branch
2 times, most recently
from
a88e1a8
to
69d060c
Compare
Signed-off-by: Tomas Langer <tomas.langer@oracle.com> Work around issues with the reduced pom created by maven-shade-plugin. See https://issues.apache.org/jira/browse/MNG-5899 Inline the reduced dependencies in the original pom. Turn-off reduced pom generation. Update microprofile/weld/pom.xml Build fixes after repackaging weld. Build fix - spotbugs exclude missing. Simplify build and runtime events. Using predefined priorities. Validations for all modules in test. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
force-pushed
the
716-mp-revamp
branch
from
69d060c
to
8f464f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major revamp of MicroProfile bootstrap.
A lot of changes related to native image.
This does not resolve the issue, though is a big step towards it (#716)