Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Can't interact with objects related to a repository that doesn't exist anymore #4332

Closed
BaptisteGi opened this issue Sep 11, 2024 · 1 comment
Assignees
Labels
priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release type/bug Something isn't working as expected

Comments

@BaptisteGi
Copy link
Contributor

BaptisteGi commented Sep 11, 2024

Component

API Server / GraphQL, Git Integration

Infrahub version

0.16.0

Current Behavior

I tried to delete a GraphQL query (using UI or GraphQL client) related to a repository that doesn't exist anymore.

UI is broken and when trying to delete the object using Graphiql client it fails as well complaining that related repository doesn't exist anymore.

image

image

Other objects for instance check definition are impacted as well.

Expected Behavior

I expect to be able to list and delete those objects even tho the related repository doesn't exist anymore. Or alternatively, object is deleted at the same time as the related repository (as described in issue #3076)

Steps to Reproduce

  • invoke dev.buid dev.start
  • Add repository https://github.com/BaptisteGi/basic-repo
  • Wait for the repo to be initialized ...
  • Create new branch
  • Add a tag
  • Create proposed change
  • Go back to main
  • Delete the repository
  • Reach to GraphQL query page and/or

Additional Information

It's important to run check through proposed change once to reproduce the bug

@BaptisteGi BaptisteGi added the type/bug Something isn't working as expected label Sep 11, 2024
@exalate-issue-sync exalate-issue-sync bot added the priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release label Nov 26, 2024
@exalate-issue-sync exalate-issue-sync bot added this to the Infrahub - 1.0.x milestone Dec 11, 2024
Copy link

[From ajtmccarty]

the fix for this implemented in [https://github.com//pull/5133|https://github.com//pull/5133|smart-link] is to prevent deleting the repository when it has linked mandatory relationships in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release type/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

3 participants