Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: schema diff view in the branch detail page is not working #4093

Closed
wvandeun opened this issue Aug 13, 2024 · 2 comments
Closed

bug: schema diff view in the branch detail page is not working #4093

wvandeun opened this issue Aug 13, 2024 · 2 comments
Assignees
Labels
group/frontend Issue related to the frontend (React) type/bug Something isn't working as expected

Comments

@wvandeun
Copy link
Contributor

Component

Frontend UI, API Server / GraphQL

Infrahub version

0.16.0.dev0

Current Behavior

The schema diff view in the branch detail page is now showing schema changes when you made changes to the schema in that branch.

The schema diff view for a proposed change for that same branch will show you the schema diff.

Expected Behavior

The branch detail page should show the schema diff

Steps to Reproduce

  • spin up instance of infrahub
  • create a new branch
  • load this schema in that newly created branch
---
version: "1.0"
nodes:
  - name: ANode
    namespace: Infra
    label: "ANode"
    display_labels:
      - name__value
    attributes:
      - name: name
        kind: Text
        unique: true
    relationships:
      - name: other_node
        peer: InfraBNode
        kind: Attribute
        cardinality: one
  - name: BNode
    namespace: Infra
    menu_placement: InfraANode
    label: "BNode"
    display_labels:
      - name__value
    attributes:
      - name: name
        kind: Text
        unique: true
  • in the frontend open the branch detail page, click on diff and open the schema tab

Additional Information

Tagged the issue for both frontend and backend, didn't look into the details to determine where the issue exactly is.

@wvandeun wvandeun added the type/bug Something isn't working as expected label Aug 13, 2024
@dgarros dgarros added this to the Infrahub - 0.16 milestone Aug 26, 2024
@dgarros
Copy link
Collaborator

dgarros commented Aug 26, 2024

there's been a lot of changes to the diff last week, would be good to double check if this issue is still present after the freeze

@exalate-issue-sync exalate-issue-sync bot added the state/planned This issue is planned to be worked on in an upcoming release. label Aug 27, 2024
Copy link

[From wvandeun]

This issue still present. And if you click on the new button to “Refresh diff” view you get an error message that $branchName is required but not provided

@exalate-issue-sync exalate-issue-sync bot added the group/frontend Issue related to the frontend (React) label Aug 27, 2024
@exalate-issue-sync exalate-issue-sync bot removed the state/planned This issue is planned to be worked on in an upcoming release. label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/frontend Issue related to the frontend (React) type/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

3 participants