Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http and https_proxy support #120

Merged
merged 5 commits into from
May 23, 2013
Merged

Add http and https_proxy support #120

merged 5 commits into from
May 23, 2013

Conversation

adamhjk
Copy link
Contributor

@adamhjk adamhjk commented May 21, 2013

Enable http and http_proxy support for calls made within the vm, through putting env http_proxy and https_proxy in front of the ssh commands run inside the VM.

@fnichol
Copy link
Contributor

fnichol commented May 23, 2013

Clever, I like this! Would that be propagated and used in a chef-{solo,client} run? This should work for debian packages too I believe. Oh, and even the Omnibus package downloads?

fnichol added a commit that referenced this pull request May 23, 2013
Add http and https_proxy support
@fnichol fnichol merged commit eaa24e7 into master May 23, 2013
@adamhjk
Copy link
Contributor Author

adamhjk commented May 23, 2013

It should propagate to most things. A few, like yum, only honor their own internal proxy values. But yeah, it covers the omnibus downloads, busser gems, etc.

Adam

Sent from my iPhone

On May 23, 2013, at 12:22 AM, "Fletcher Nichol" <notifications@github.commailto:notifications@github.com> wrote:

Clever, I like this! Would that be propagated and used in a chef-{solo,client} run? This should work for debian packages too I believe. Oh, and even the Omnibus package downloads?

Reply to this email directly or view it on GitHubhttps://github.com//pull/120#issuecomment-18322681.

@fnichol
Copy link
Contributor

fnichol commented May 23, 2013

This is going to rock

@jtimberman jtimberman deleted the http_proxy branch May 24, 2013 03:50
@obazoud obazoud mentioned this pull request Oct 31, 2014
@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants