Can't install on macOS.

[dfrico]

Hi!

Running cargo install dijo on macOS gives the following error when compiling cursive_core:

error[E0658]: use of unstable library feature 'mem_take'
    --> /Users/blayhem/.cargo/registry/src/github.com-1ecc6299db9ec823/cursive_core-0.1.1/src/cursive.rs:1027:22
     |
1027 |             menubar: std::mem::take(&mut self.menubar),
     |                      ^^^^^^^^^^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/61129.

Installing on macOS Catalina 10.15.6 (Darwin Kernel Version 19.6.0).

The rustlang issue it mentions.

Extra info on verbose:

Caused by:
  process didn't exit successfully: `rustc --edition=2018 --crate-name cursive_core /Users/blayhem/.cargo/registry/src/github.com-1ecc6299db9ec823/cursive_core-0.1.1/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C metadata=3c53a3f6c9cd6f98 -C extra-filename=-3c53a3f6c9cd6f98 --out-dir /var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps -L dependency=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps --extern ahash=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libahash-390727df5c48f09b.rmeta --extern chrono=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libchrono-3d1ee4cd8928312b.rmeta --extern crossbeam_channel=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libcrossbeam_channel-e838f77927b8b2af.rmeta --extern enum_map=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libenum_map-ef63d0120ef54768.rmeta --extern enumset=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libenumset-cf80cbc7fa56a9d4.rmeta --extern lazy_static=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/liblazy_static-fe362d3d05674e2b.rmeta --extern libc=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/liblibc-ab9f31dc62f2a5ec.rmeta --extern log=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/liblog-69e6d683a7ca371d.rmeta --extern num=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libnum-e76c036f38435412.rmeta --extern owning_ref=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libowning_ref-5ddc135c6c3b9bb6.rmeta --extern signal_hook=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libsignal_hook-674910caa72dac21.rmeta --extern unicode_segmentation=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libunicode_segmentation-0aee55a362fa5307.rmeta --extern unicode_width=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libunicode_width-95ffd67991814be7.rmeta --extern xi_unicode=/var/folders/1w/3_9z50k12_g87db33k74pvdc0000gn/T/cargo-install1EbFyp/release/deps/libxi_unicode-e8afc9f4d9f6b2e0.rmeta --cap-lints allow` (exit code: 1)

[oppiliappan]

Could you tell me the output of rustc -V?

[dfrico]

Could you tell me the output of rustc -V?

My bad 🤦 it was rustc 1.38.0. I updated it up to 1.45.0 and it installed without any issues. Thanks!

Is it worth it to add a required minimum version to the README?

[oppiliappan]

Ah I see, that's great!

Yep, that one's on me, I had hadded MSRV to the wiki, forgot to do the same on the readme file.