Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git hook pre-commits should be implemented #161

Open
brianroch opened this issue Mar 31, 2023 · 0 comments
Open

Git hook pre-commits should be implemented #161

brianroch opened this issue Mar 31, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@brianroch
Copy link
Contributor

brianroch commented Mar 31, 2023

pre-commit is a good tool that could be leveraged.

Checks should match the linting and formatting checks that are performed by the workflows. They could then be executed locally by developers instead of relying on these checks only being performed after updating a PR.

IMO, we shouldn't enforce tests to be green on every local commit using this tool. I think this discourages frequent commits and there are times when tests will be broken in the middle of a refactor. We should rely on contributors to execute tests locally as required. Instead the scope should just be for linting and formatting checks.

@glimchb glimchb added the good first issue Good for newcomers label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants