Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dependencies manager detects conflicting when mixing dep and module in one project #1738

Closed
dmvolod opened this issue Jul 25, 2019 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@dmvolod
Copy link
Contributor

dmvolod commented Jul 25, 2019

Feature Request

Is your feature request related to a problem? Please describe.
We had a problem (right now, we used a workaround) in camel-k problem https://github.com/apache/camel-k
When project could use in the same time mixing dep and module dependencies managers, the 'operator-sdk build' command always use dep whether GO111MODULE set or not.
Right now, dependencies manager detection mechanism starts with looking for gopkgTOMLFile or goModFile and next for just GO111MODULE.

Describe the solution you'd like
It would be nice to change priority for detecting dependencies manager.

  • first, look for GO111MODULE settings
  • if it set to "on" check for goModFile
  • if not set or set to auto, look for goModFile or gopkgTOMLFile

I'm ready to provide fix for this solution. Any feedback's are appreciate.

@dmvolod
Copy link
Contributor Author

dmvolod commented Jul 30, 2019

@shawn-hurley , @jmrodri, @hasbro17 @lilic could you please to look at this request. If it suitable, i can provide a PR for it. Thank you.

@dmvolod
Copy link
Contributor Author

dmvolod commented Aug 1, 2019

@joelanford could you please to look at this issue also?

@joelanford
Copy link
Member

@dmvolod I'm not opposed to accepting a change for this (assuming @estroz agrees with the logic). However, we're planning to completely drop support for dep when Go 1.13 is released. If history is any indication, that should be sometime this month, so it might make sense to just wait for that.

@joelanford joelanford self-assigned this Aug 1, 2019
@joelanford joelanford added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 1, 2019
@estroz
Copy link
Member

estroz commented Aug 1, 2019

@joelanford this priority change is ok with me. @dmvolod feel free to submit a PR, or I can whip one up. Thanks!

@estroz estroz assigned estroz and unassigned joelanford Aug 1, 2019
@dmvolod
Copy link
Contributor Author

dmvolod commented Aug 2, 2019

Thanks @joelanford and @estroz for response.
I will provide PR as well as submit a new issue related to the "dep drop support" and assign it with Go1.13 release milestone (https://github.com/golang/go/milestone/83) for tracking, and could help with it if possible.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2019
@estroz
Copy link
Member

estroz commented Oct 31, 2019

@dmvolod the SDK has upgraded to go 1.13 and dropped support for dep/Gopkg.toml in new projects. We recommend upgrading to v0.12.0. If you still have trouble with your dual dependency management issue, feel free to submit a patch PR to the v0.11.x branch and we can look into getting that merged. I will reopen this issue if that is the case.

@estroz estroz closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants