Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit pipeline command-related permissions #1327

Closed
christophermaier opened this issue Jan 25, 2017 · 1 comment · Fixed by #1370
Closed

Revisit pipeline command-related permissions #1327

christophermaier opened this issue Jan 25, 2017 · 1 comment · Fixed by #1370
Assignees

Comments

@christophermaier
Copy link
Collaborator

This was a left-over nice-to-have from #1320:

Revisit permissions - Currently any user can view the pipeline history
for any other user. LIkewise any user can kill any other user's executing
pipelines. I'm not sure this is the desired behavior. I can make convincing 
arguments for both sides.
@christophermaier christophermaier added this to the Cog 1.0 milestone Jan 25, 2017
@kevsmith
Copy link
Member

kevsmith commented Feb 20, 2017

I think we'd like to lock down exactly who can see other users' histories and pipelines. We don't have an easy way to express this via rules currently, sadly. I think the expedient thing to do is:

  1. Allow any user to view their own histories and manage their own pipelines.
  2. Allow only members of the cog-admins group to view other users' histories manage other users' pipelines.

Alternatively we could add two new permissions, operable:view-user-history and operable:manage-user-pipeline, and limit access to other users' histories and pipelines to only users who have these permissions.

In any case we'll have to hard code these checks into the relevant commands since the rule language doesn't have a way to express data ownership. While a little hacky I think this is acceptable since the history and pipeline commands are part of the embedded bundle.

@mpeck mpeck self-assigned this Feb 20, 2017
@mpeck mpeck added the review label Feb 22, 2017
@mpeck mpeck removed the review label Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants