Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempts to deflake postSpans_disconnectDuringBody #3635

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Attempts to deflake postSpans_disconnectDuringBody #3635

merged 1 commit into from
Dec 14, 2023

Conversation

codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt commented Dec 13, 2023 •
edited
Loading

fixes #3634

@codefromthecrypt
Copy link
Member Author

first run flake was #3633 not about postSpans

@codefromthecrypt codefromthecrypt mentioned this pull request Dec 13, 2023
Merged
Attempts to deflake postSpans_disconnectDuringBody
8132038 
Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt
Copy link
Member Author

one pass and kicked

@codefromthecrypt
Copy link
Member Author

second pass no flake, kicked

@codefromthecrypt
Copy link
Member Author

third no flake, kicking

@codefromthecrypt codefromthecrypt marked this pull request as ready for review December 14, 2023 07:44
@codefromthecrypt
Copy link
Member Author

4x green in a row isn't a guarantee, but it is hope!

@codefromthecrypt codefromthecrypt merged commit 876a215 into master Dec 14, 2023
11 checks passed
@codefromthecrypt codefromthecrypt deleted the flake-try-2 branch December 14, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flakey test: ZipkinExtensionTest.postSpans_disconnectDuringBody
2 participants
@codefromthecrypt @anuraaga