Title of HTML page is not updated anymore in 3.0

[kelson42]

All the pages have the same title, see:

[dan-niles]

Should the page title include only the video title (e.g., Les Délires de Maisons de Milliardaires !), or should it also include the ZIM title (e.g., Astrolabe | Les Délires de Maisons de Milliardaires !)?

[kelson42]

@dan-niles At this stage, I would do it like it was before, so only the video title. Same for playlist page, etc...

[benoit74]

This is not really a regression but an intended change, discussed in #227

The reason behind it is that we know have one single HTML entry. And the content is dynamically updated with JS. We could hence also update the title dynamically from JS (this is the PR). I tried and failed in kolibri (but maybe my code was different, I do not recall). As far as I remember, some readers where not detecting the dynamic change of document title at all (not really a problem but a waste of code/energy) and some other readers (kiwix-serve if I'm not mistaken) where mixing up titles in browser history: looked like page N had the title of page N-1 in history.

[benoit74]

I did not intended to close this issue at all, sorry, missclick.

[benoit74]

I will test the ZIM built in the PR and revert.

[benoit74]

As mentioned in #300 (review), I did not experienced again the issues I experienced with Kolibri. I'm probably not as a good frontend dev as @dan-niles ^^ Glad it works as expected.