Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade video.js version to fix issue with minification on Chrome 51-59 #275

Closed
dan-niles opened this issue Jul 23, 2024 · 4 comments · Fixed by #290
Closed

Upgrade video.js version to fix issue with minification on Chrome 51-59 #275

dan-niles opened this issue Jul 23, 2024 · 4 comments · Fixed by #290
Assignees
Labels
Milestone

Comments

@dan-niles
Copy link
Collaborator

As mentioned in #272 (comment), once video.js releases a new version with the videojs/video.js#8810 patch we should update video.js in the zimui and check if video playback works on Chrome 51-59.

@dan-niles dan-niles added the task label Jul 23, 2024
@dan-niles dan-niles changed the title Upgrade video.js version to fix issue with minification in Chrome 51-59 Upgrade video.js version to fix issue with minification on Chrome 51-59 Jul 23, 2024
@benoit74 benoit74 added this to the 3.1.0 milestone Jul 23, 2024
@benoit74 benoit74 modified the milestones: 3.1.0, 3.0.1 Aug 9, 2024
@benoit74
Copy link
Collaborator

benoit74 commented Aug 9, 2024

New version is ready, see videojs/video.js#8810 (comment)

@dan-niles could you test this so that we include it in the soon coming 3.0.1 release?

@benoit74
Copy link
Collaborator

benoit74 commented Aug 9, 2024

Oh no, it is not yet published on NPM, we still have to wait a bit

@dan-niles
Copy link
Collaborator Author

I tested out video.js v8.17.3. Good news is the UI is finally loading in Chrome v59-52. (Chrome 51 is still not working)

  • Everything (UI + Video playback) works fine on Chrome v59 and v58.
  • On Chrome v57-52 the thumbnails are not loading and video.js displays an error as shown below. Sometimes when I reload the page the video playback works.
image image This needs to be investigated further.

@dan-niles dan-niles self-assigned this Aug 9, 2024
@dan-niles
Copy link
Collaborator Author

Opened #291 to track this seperately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants